All SOG DLC underwear uniforms on a player take the camo1 hiddenselectiontexture value from the last uniform worn, instead of the defined one in the base underwear class. This issue affects all sides and classes except for tee shirt uniforms.

REPRO:

1 In editor navigate to empty / vietnam / uniforms and place down 2 different uniforms on the floor "vn_b_uniform_item_seal_08_03" and "vn_b_uniform_item_macv_06_17" (tee shirt).

2 Place playable characters "vn_b_men_sog_23" El Cid and "vn_b_men_sog_22" Chief SOG (he has a tee shirt)

3 as El Cid, in mission, enter inventory and remove your uniform - note underwear is taking the texture from the uniform placed down. Pick up vn_b_uniform_item_macv_06_17 and place it down again. Note underwear now takes correct texture.

4 as Chief SOG, in mission, enter inventory and remove your uniform - note underwear is taking the correct texture from the underwear. Pick up vn_b_uniform_item_seal_08_03 and place it down again. Note underwear now takes texture from the uniform placed down.

All classes are affected by having nakedUniform = "vn_b_uniform_basecharacter_01"; or 02

This appears to be because the two SOG underwear models have a hiddenselectionstexture camo assigned.

ANALYSIS:

class vn_b_men_sog_base: B_Soldier_base_F
{
nakedUniform = "vn_b_uniform_basecharacter_01";
hiddenSelections[] =
{
"camo1", //shirt
"camo2", //pants
"insignia", //arm patch
"d_pocket_l", //leftchest unit patch
"d_pocket_r" //right chest badge
};
model = "\vn\characters_f_vietnam\BLUFOR\uniforms\vn_b_sog_bdu_01";
uniformClass = "vn_b_uniform_sog_01_01";
hiddenSelectionsTextures[] =
{ "\vn\characters_f_vietnam\BLUFOR\uniforms\data\vn_b_uniform_shirt_01_co.paa",
"\vn\characters_f_vietnam\BLUFOR\uniforms\data\vn_b_uniform_pants_01_co.paa"
};
};

class vn_b_men_army_base: vn_b_men_sog_base
{
model = "\vn\characters_f_vietnam\BLUFOR\uniforms\vn_b_macv_bdu_01";
uniformClass = "vn_b_uniform_macv_01_01";
hiddenSelectionsTextures[] =
{ "\vn\characters_f_vietnam\BLUFOR\uniforms\data\vn_b_uniform_shirt_01_co.paa", "\vn\characters_f_vietnam\BLUFOR\uniforms\data\vn_b_uniform_pants_01_co.paa"
};
};

OFFICER - FAILS

class vn_b_men_army_01: vn_b_men_army_base
{
model = "\vn\characters_f_vietnam\BLUFOR\uniforms\vn_b_macv_bdu_01";
uniformClass = "vn_b_uniform_macv_01_01";
hiddenSelectionsTextures[] =
{ "\vn\characters_f_vietnam\BLUFOR\uniforms\data\vn_b_uniform_shirt_01_co.paa", "\vn\characters_f_vietnam\BLUFOR\uniforms\data\vn_b_uniform_pants_01_co.paa"
};
};

TUNNEL RAT - WORKS

class vn_b_men_army_26: vn_b_men_army_base
{
model = "\vn\characters_f_vietnam\BLUFOR\uniforms\vn_b_macv_bdu_06";
uniformClass = "vn_b_uniform_macv_06_01";
hiddenSelectionsTextures[] =
{ "\vn\characters_f_vietnam\BLUFOR\uniforms\data\vn_basecharacter_01_co.paa", "\vn\characters_f_vietnam\BLUFOR\uniforms\data\vn_b_uniform_pants_01_co.paa"
};
};

so the only differences are:

1. uniformclass - but these are almost identical content bar the reference to the soldier units we're already looking at here.

2. model. comparing models - the only difference is the assignation of textures

3. camo2 is assigned to the base uniform texture in both working and failing classes

4. camo1 texture is assigned to basecharacter in the working uniform, but assigned to the base uniform texture in the failing class. This is true in both the model and the soldier class

HYPOTHESIS:
working model (06):
- has underwear texture assigned to camo1 in both model and soldier class
failing model (01)
- has uniform texture assigned to camo1 in both model and soldier class
So it could be either:
A. the model assignation, or
B. the soldier class camo1 assignation

TESTS:
A. patch officer model to assign underwear shirt class to camo1 in model
B. patch officer class to assign underwear shirt class to camo1 in config

FINDINGS:
Patching the officer soldier class so he has camo1 assigned to the underwear texture clearly breaks the expected uniform texture, BUT the underwear model now shows the correct texture when the uniform is dropped

Patching the tunnel rat soldier class DOES NOT change his uniform appearance The patch below does NOTHING This is because uniformclass vn_b_uniform_macv_06_01 is pointing to vn_b_men_army_21

Patching soldier 21 - the tunnel rat now has duck textures on shirt and pants. clearly the shirt texture UV doesnt line up as it should be the underwear texture assigned. What happens now when we drop the uniform? the underwear has the camo1 uniform selection still. so we broke this uniform by not assigning the underwear to camo1 in the soldier class related to the uniformclass definition in the class of uniform worn by the soldier.

CONCLUSION:

Contrary to the time when SOG DLC was released, vanilla Arma 3 now expects the first texture assignment in the soldier class hiddenselectionstextures to be the underwear texture, for it to carry across to the underwear once the soldier takes off the uniform. I am unsure why this change was made, as it breaks all of our uniforms, which do not have basecharacter (underwear) uniforms defined in the soldier classes at all. These textures are assigned as normal, as camo index 0 textures in our underwear uniform classes It seems that the camo selection in the underwear models are now overwritten by the engine, taking the texture instead from the uniformclass' referenced soldier class' hiddenselectionstextures index 0. Question to BI: Was this expected / planned? If so, we'll need to patch all our uniform/ soldier classes to address the issue - by adding an additional camo selection to all our soldiers, pointing to the underwear texture. This will likely BREAK ALL MODS using units / uniforms derived from SOG.

We lucked out here because our "teeshirt uniform" models use the underwear texture for the top half camo selection. Otherwise we probably would never have worked this out!

ISSUE IN FOCUS

what used to be the case: base character class had hiddenselectionstextures assigned directly in the class. This is the texture seen on the underwear when the player drops their current uniform.
what is now the case: base character class now takes its texture from the index 0 of the most recent uniformclass that was dropped.

TEMP FIX

In Nickel Steel mod (35k users) we are patching the 2 underwear classes as follows:
- removed camo class from underwear models to fix misassignment issue with vanilla behaviour introduced since DLC release.
class vn_basecharacter_01: B_Soldier_base_F
{
hiddenSelections[] =
{
// "camo" //removed to fix incorrect assignment of uniformclass index 0 hiddesnselectionstextures to underwear when uniform is dropped
};
hiddenSelectionsTextures[] =
{
// "\vn\characters_f_vietnam\blufor\uniforms\data\vn_basecharacter_01_co.paa"
};
//
};
//same for vn_basecharacter_02 (nva underwear)

However SOG DLC (410k users) will still experience this issue with 95% of our 200+ uniforms (the ones without teeshirts).